Thanks Andrew and Serban. I submitted a patch for it.

________________________________________ From: Serban Constantinescu serbanc@google.com Sent: 27 May 2020 13:57 To: Olivier Deprez; Andrew Scull Cc: hafnium@lists.trustedfirmware.org Subject: Re: [Hafnium] CPTR_EL2 configuration

+Andrew Scullmailto:ascull@google.com who kindly answered this offline.

On Fri, May 22, 2020 at 9:38 AM Olivier Deprez via Hafnium <hafnium@lists.trustedfirmware.orgmailto:hafnium@lists.trustedfirmware.org> wrote: Hi,

Hafnium sets CPTR_EL2.TTA (bit 28), which traps accesses to trace system registers to EL2. https://git.trustedfirmware.org/hafnium/hafnium.git/tree/src/arch/aarch64/sy...

However CPTR_EL2 register has a different bit field definition depending on HCR_EL2.E2H state. When HCR_EL2.E2H=0 (Hafnium case) CPTR_EL2.TTA bit position is 20.

Is this a slight issue needing fix?

It sounds like this was copied badly from the spec and should be fixed. We don't enable VHE and we should do as the spec says.

HTH, Serban

Regards, Olivier. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -- Hafnium mailing list Hafnium@lists.trustedfirmware.orgmailto:Hafnium@lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/hafnium