Hi Andrew,
We seem to reach a consensus within ARM that it is something we can enable. As a slight usage detail, we'd expect developers to use their initials for gerrit topics such a xy/topic-name. That's already recommended for TF-A, although not always enforced. This would avoid unintended/accidental merges in different repos because of gerrit topic name clashes.
Does it make sense?
Other folks in the ML, please shout if you disagree (you can also express that you agree 🙂).
Regards, Olivier.
________________________________ From: Andrew Walbran Sent: Wednesday, July 01, 2020 11:28 To: hafnium@lists.trustedfirmware.org; Benjamin Copeland; Olivier Deprez Subject: Re: change.submitWholeTopic option for Gerrit
Any thoughts on this?
On Fri, 26 Jun 2020 at 21:21, Andrew Walbran <qwandor@google.commailto:qwandor@google.com> wrote: Hello, How would people feel about enabling the change.submitWholeTopic option (https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#chan...) for Gerrit?
So far, we have relied on this to ensure that submodule changes get submitted along with the corresponding change to the main repository. Our usual workflow has been that whenever a change is made to one of the submodule repositories, both that change and the corresponding change to the main repository are tagged with the same topic. That way it is only possible to submit either once they have all been reviewed +2 and the main change has passed presubmit. This avoids submodules getting out of sync or changes to them being missed or not properly tested.
However, it looks like this is a per-host configuration option rather than per-repository, so it would also affect the other Trusted Firmware projects using the same Gerrit host. Are there any other uses of topics there which would conflict with this config change?
(If there are other people who might have an opinion on this please add them to the thread.)
Hi Andrew,
We seem to reach a consensus within ARM that it is something we can enable. As a slight usage detail, we'd expect developers to use their initials for gerrit topics such a xy/topic-name. That's already recommended for TF-A, although not always enforced. This would avoid unintended/accidental merges in different repos because of gerrit topic name clashes.
Does it make sense?
Other folks in the ML, please shout if you disagree (you can also express that you agree 🙂).
Regards, Olivier.
________________________________ From: Andrew Walbran Sent: Wednesday, July 01, 2020 11:28 To: hafnium@lists.trustedfirmware.org; Benjamin Copeland; Olivier Deprez Subject: Re: change.submitWholeTopic option for Gerrit
Any thoughts on this?
On Fri, 26 Jun 2020 at 21:21, Andrew Walbran <qwandor@google.commailto:qwandor@google.com> wrote: Hello, How would people feel about enabling the change.submitWholeTopic option (https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#chan...) for Gerrit?
So far, we have relied on this to ensure that submodule changes get submitted along with the corresponding change to the main repository. Our usual workflow has been that whenever a change is made to one of the submodule repositories, both that change and the corresponding change to the main repository are tagged with the same topic. That way it is only possible to submit either once they have all been reviewed +2 and the main change has passed presubmit. This avoids submodules getting out of sync or changes to them being missed or not properly tested.
However, it looks like this is a per-host configuration option rather than per-repository, so it would also affect the other Trusted Firmware projects using the same Gerrit host. Are there any other uses of topics there which would conflict with this config change?
(If there are other people who might have an opinion on this please add them to the thread.)
That sounds like a good plan to me. We can add a note to https://review.trustedfirmware.org/plugins/gitiles/hafnium/hafnium/+/HEAD/CO... about using your initials for topics.
On Thu, 9 Jul 2020 at 13:47, Olivier Deprez Olivier.Deprez@arm.com wrote:
Hi Andrew,
We seem to reach a consensus within ARM that it is something we can enable. As a slight usage detail, we'd expect developers to use their initials for gerrit topics such a xy/topic-name. That's already recommended for TF-A, although not always enforced. This would avoid unintended/accidental merges in different repos because of gerrit topic name clashes.
Does it make sense?
Other folks in the ML, please shout if you disagree (you can also express that you agree 🙂).
Regards, Olivier.
*From:* Andrew Walbran *Sent:* Wednesday, July 01, 2020 11:28 *To:* hafnium@lists.trustedfirmware.org; Benjamin Copeland; Olivier Deprez *Subject:* Re: change.submitWholeTopic option for Gerrit
Any thoughts on this?
On Fri, 26 Jun 2020 at 21:21, Andrew Walbran qwandor@google.com wrote:
Hello, How would people feel about enabling the change.submitWholeTopic option ( https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#chan...) for Gerrit?
So far, we have relied on this to ensure that submodule changes get submitted along with the corresponding change to the main repository. Our usual workflow has been that whenever a change is made to one of the submodule repositories, both that change and the corresponding change to the main repository are tagged with the same topic. That way it is only possible to submit either once they have all been reviewed +2 and the main change has passed presubmit. This avoids submodules getting out of sync or changes to them being missed or not properly tested.
However, it looks like this is a per-host configuration option rather than per-repository, so it would also affect the other Trusted Firmware projects using the same Gerrit host. Are there any other uses of topics there which would conflict with this config change?
(If there are other people who might have an opinion on this please add them to the thread.)
hafnium@lists.trustedfirmware.org
-
Andrew Walbran -
Olivier Deprez