Hi,
Can I get please get some reviews on the GIC patch series [1]? It is a real problem on NVIDIA Tegra platforms and the series solves the issue.
Thanks.
[1] topic:"gicv3-gicr-frames" (status:open OR status:merged) * Gerrit Code Review (trustedfirmware.org)https://review.trustedfirmware.org/q/topic:%22gicv3-gicr-frames%22+(status:open%20OR%20status:merged)
Hi Varun,
Joao and I left minor comments and I think the change will be good to go.
Can you make sure to update submodule hash in first change as suggested by Joao to ensure changes get Verified+1 votes by automation?
Thanks, Olivier.
________________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: 04 April 2022 14:37 To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] Request for review: parse all GICR frames on a platform
Hi,
Can I get please get some reviews on the GIC patch series [1]? It is a real problem on NVIDIA Tegra platforms and the series solves the issue.
Thanks.
[1] topic:"gicv3-gicr-frames" (status:open OR status:merged) * Gerrit Code Review (trustedfirmware.org)https://review.trustedfirmware.org/q/topic:%22gicv3-gicr-frames%22+(status:open%20OR%20status:merged) -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Hi Olivier and Joao,
Thanks for the feedback. I have pushed updates to the commits.
Hopefully, the latest updates fix the failure in CI.
-Varun
-----Original Message----- From: Olivier Deprez Olivier.Deprez@arm.com Sent: Monday, 4 April 2022 5:15 PM To: hafnium@lists.trustedfirmware.org; Varun Wadekar vwadekar@nvidia.com Subject: Re: Request for review: parse all GICR frames on a platform
External email: Use caution opening links or attachments
Hi Varun,
Joao and I left minor comments and I think the change will be good to go.
Can you make sure to update submodule hash in first change as suggested by Joao to ensure changes get Verified+1 votes by automation?
Thanks, Olivier.
________________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: 04 April 2022 14:37 To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] Request for review: parse all GICR frames on a platform
Hi,
Can I get please get some reviews on the GIC patch series [1]? It is a real problem on NVIDIA Tegra platforms and the series solves the issue.
Thanks.
[1] topic:"gicv3-gicr-frames" (status:open OR status:merged) * Gerrit Code Review (trustedfirmware.org)https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fq%2Ftopic%3A%2522gicv3-gicr-frames%2522&data=04%7C01%7Cvwadekar%40nvidia.com%7Cfbdde2dae3824401d78c08da16564c0c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637846857565287168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=R83DclmxQWdL3GhFmCeX3m5rZfkLMqqgRIGeBOzIriU%3D&reserved=0+(status:open%20OR%20status:merged) -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Hi Varun,
The commit hash from 'project/reference' submodule was still not correct. I have changed it manually, restarted the CI and it seems it managed to fetch the proper commit this round. Could you please fetch the latest state of those changes (to preserve the commit hash values, sometimes fetch/rebasing can affect these), fix the two small comments in https://review.trustedfirmware.org/c/hafnium/hafnium/+/13920/comment/9c5f753... and push again? Cheers, João Alves
________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: Monday, April 4, 2022 9:26 PM To: Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: Request for review: parse all GICR frames on a platform
Hi Olivier and Joao,
Thanks for the feedback. I have pushed updates to the commits.
Hopefully, the latest updates fix the failure in CI.
-Varun
-----Original Message----- From: Olivier Deprez Olivier.Deprez@arm.com Sent: Monday, 4 April 2022 5:15 PM To: hafnium@lists.trustedfirmware.org; Varun Wadekar vwadekar@nvidia.com Subject: Re: Request for review: parse all GICR frames on a platform
External email: Use caution opening links or attachments
Hi Varun,
Joao and I left minor comments and I think the change will be good to go.
Can you make sure to update submodule hash in first change as suggested by Joao to ensure changes get Verified+1 votes by automation?
Thanks, Olivier.
________________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: 04 April 2022 14:37 To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] Request for review: parse all GICR frames on a platform
Hi,
Can I get please get some reviews on the GIC patch series [1]? It is a real problem on NVIDIA Tegra platforms and the series solves the issue.
Thanks.
[1] topic:"gicv3-gicr-frames" (status:open OR status:merged) * Gerrit Code Review (trustedfirmware.org)https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fq%2Ftopic%3A%2522gicv3-gicr-frames%2522&data=04%7C01%7Cvwadekar%40nvidia.com%7Cfbdde2dae3824401d78c08da16564c0c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637846857565287168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=R83DclmxQWdL3GhFmCeX3m5rZfkLMqqgRIGeBOzIriU%3D&reserved=0+(status:open%20OR%20status:merged) -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Just as a matter of concluding this thread: those changes are now merged.
________________________________________ From: Joao Alves Joao.Alves@arm.com Sent: 05 April 2022 11:09 To: Varun Wadekar Cc: Olivier Deprez; hafnium@lists.trustedfirmware.org Subject: Re: Request for review: parse all GICR frames on a platform
Hi Varun,
The commit hash from 'project/reference' submodule was still not correct. I have changed it manually, restarted the CI and it seems it managed to fetch the proper commit this round. Could you please fetch the latest state of those changes (to preserve the commit hash values, sometimes fetch/rebasing can affect these), fix the two small comments in https://review.trustedfirmware.org/c/hafnium/hafnium/+/13920/comment/9c5f753... and push again? Cheers, João Alves
________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: Monday, April 4, 2022 9:26 PM To: Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: Request for review: parse all GICR frames on a platform
Hi Olivier and Joao,
Thanks for the feedback. I have pushed updates to the commits.
Hopefully, the latest updates fix the failure in CI.
-Varun
-----Original Message----- From: Olivier Deprez Olivier.Deprez@arm.com Sent: Monday, 4 April 2022 5:15 PM To: hafnium@lists.trustedfirmware.org; Varun Wadekar vwadekar@nvidia.com Subject: Re: Request for review: parse all GICR frames on a platform
External email: Use caution opening links or attachments
Hi Varun,
Joao and I left minor comments and I think the change will be good to go.
Can you make sure to update submodule hash in first change as suggested by Joao to ensure changes get Verified+1 votes by automation?
Thanks, Olivier.
________________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: 04 April 2022 14:37 To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] Request for review: parse all GICR frames on a platform
Hi,
Can I get please get some reviews on the GIC patch series [1]? It is a real problem on NVIDIA Tegra platforms and the series solves the issue.
Thanks.
[1] topic:"gicv3-gicr-frames" (status:open OR status:merged) * Gerrit Code Review (trustedfirmware.org)https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fq%2Ftopic%3A%2522gicv3-gicr-frames%2522&data=04%7C01%7Cvwadekar%40nvidia.com%7Cfbdde2dae3824401d78c08da16564c0c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637846857565287168%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=R83DclmxQWdL3GhFmCeX3m5rZfkLMqqgRIGeBOzIriU%3D&reserved=0+(status:open%20OR%20status:merged) -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Thanks Olivier and Joao.
-----Original Message----- From: Olivier Deprez Olivier.Deprez@arm.com Sent: Monday, 11 April 2022 7:27 AM To: Joao Alves Joao.Alves@arm.com; Varun Wadekar vwadekar@nvidia.com Cc: hafnium@lists.trustedfirmware.org Subject: Re: Request for review: parse all GICR frames on a platform
External email: Use caution opening links or attachments
Just as a matter of concluding this thread: those changes are now merged.
________________________________________ From: Joao Alves Joao.Alves@arm.com Sent: 05 April 2022 11:09 To: Varun Wadekar Cc: Olivier Deprez; hafnium@lists.trustedfirmware.org Subject: Re: Request for review: parse all GICR frames on a platform
Hi Varun,
The commit hash from 'project/reference' submodule was still not correct. I have changed it manually, restarted the CI and it seems it managed to fetch the proper commit this round. Could you please fetch the latest state of those changes (to preserve the commit hash values, sometimes fetch/rebasing can affect these), fix the two small comments in https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.tru... and push again? Cheers, João Alves
________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: Monday, April 4, 2022 9:26 PM To: Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: Request for review: parse all GICR frames on a platform
Hi Olivier and Joao,
Thanks for the feedback. I have pushed updates to the commits.
Hopefully, the latest updates fix the failure in CI.
-Varun
-----Original Message----- From: Olivier Deprez Olivier.Deprez@arm.com Sent: Monday, 4 April 2022 5:15 PM To: hafnium@lists.trustedfirmware.org; Varun Wadekar vwadekar@nvidia.com Subject: Re: Request for review: parse all GICR frames on a platform
External email: Use caution opening links or attachments
Hi Varun,
Joao and I left minor comments and I think the change will be good to go.
Can you make sure to update submodule hash in first change as suggested by Joao to ensure changes get Verified+1 votes by automation?
Thanks, Olivier.
________________________________________ From: Varun Wadekar via Hafnium hafnium@lists.trustedfirmware.org Sent: 04 April 2022 14:37 To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] Request for review: parse all GICR frames on a platform
Hi,
Can I get please get some reviews on the GIC patch series [1]? It is a real problem on NVIDIA Tegra platforms and the series solves the issue.
Thanks.
[1] topic:"gicv3-gicr-frames" (status:open OR status:merged) * Gerrit Code Review (trustedfirmware.org)https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.trustedfirmware.org%2Fq%2Ftopic%3A%2522gicv3-gicr-frames%2522&data=04%7C01%7Cvwadekar%40nvidia.com%7C1b152603c8384e0b9c2508da1b844a89%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637852552257301433%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=eaxroey4KbsSZM3AOvAsJq6yTCS5RBzH3S7em%2FDrINg%3D&reserved=0+(status:open%20OR%20status:merged) -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org -- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
hafnium@lists.trustedfirmware.org
-
Joao Alves -
Olivier Deprez -
Varun Wadekar