- Hafnium - lists.trustedfirmware.org

by Federico Recanati

Hi Raghu, a fix for hftest.py has been merged: https://review.trustedfirmware.org/c/hafnium/hafnium/+/12481 addressing the random failures of both-world tests and supporting connection to telnet ports other than 5000 Cheers, Federico ____________________________________ > From: raghu.ncstate(a)icloud.com <raghu.ncstate(a)icloud.com> > Sent: 04 August 2021 21:01 > To: Olivier Deprez; 'Raghu Krishnamurthy via Hafnium' > Subject: RE: [Hafnium] Bug in hftest.py > > Thanks Olivier. I've created https://developer.trustedfirmware.org/T955 to > track. Understood all of this is new. I do have local fixes to get around > the issue so not a hurry to have a fix merged, but something to consider and > fix since it will eventually show up. > >>> the both worlds test scenario is not 100% stable on my machine > [RK] Likewise. I've noticed that this is caused by lingering FVP processes. > Usually I ps -ax | grep for FVP instances, kill and then run tests and I > never see failures after that. The issue that I faced was that the lingering > FVP would take up telnet ports and the newly spawned ones use different > ports(>5004) than what hftest.py expects. It appears that when tests fail, > we may not be cleaning up/exiting processes properly, but I haven't checked. > Or the code may be just fine and a ctrl+c leaves those processes lingering. > > Thanks > Raghu > > -----Original Message----- > From: Olivier Deprez <Olivier.Deprez(a)arm.com> > Sent: Tuesday, August 3, 2021 11:51 PM > To: 'Raghu Krishnamurthy via Hafnium' <hafnium(a)lists.trustedfirmware.org>; > raghu.ncstate(a)icloud.com > Subject: Re: [Hafnium] Bug in hftest.py > > Hi Raghu, > > Thanks for reporting. > This part of the test infrastructure (testing the SPMC) is still very fresh > and requires improvement iterations so please bear with us. Also a reason > it's not yet part of the automated non-regression with jenkins (as opposed > to the legacy kokoro/test.sh). For the time being we still mostly rely on > the TF-A CI for testing on the secure side. > > IIUC this change was made to help with the test time as the FVP takes long > to reload on every test. > But indeed it might have the side effect you describe. > So either we revert the FVP reloading on every test. > Or another (somewhat hackish) possibility is to clear the mentioned > variables from within the test (or make them part of BSS)? > > To be fair, the both worlds test scenario is not 100% stable on my machine > (for some reason the connection is not always successful between the FVP and > hftest) hence limiting confidence/robustness of my testing and > investigations. So I wonder is the scripting is still somewhat a bit > fragile. > > Regards, > Olivier. > > ________________________________________ > From: Hafnium <hafnium-bounces(a)lists.trustedfirmware.org> on behalf of Raghu > Krishnamurthy via Hafnium <hafnium(a)lists.trustedfirmware.org> > Sent: 03 August 2021 23:47 > To: 'Raghu Krishnamurthy via Hafnium' > Subject: [Hafnium] Bug in hftest.py > > Hi All, > > > > Wanted to report to you that commit 18a25f9241f86ba2d637011ff465ce3869e8651b > in hafnium "appears" broken. The issue with the optimization in this patch > is that the partition images are not reloaded for each test run, which means > a previous test could have written data to say SRAM, and the following test > would use the old values from the previous test, when the same image is > executed again from SRAM for a following test. This would be a problem for > pretty much anything in the data section of a partition. In my case, I have > a counter in the data section of my partition, which does not get reset back > to its original value. > > I've attached a patch to help repro the issue. Fix is to disable the > optimization or somehow reload the images for each run. This affects only > "both world" tests. > > Let me know if I'm missing something here. > > > > Apply patch and run timeout --foreground 300s ./test/hftest/hftest.py > --out_partitions out/reference/secure_aem_v8a_fvp_vm_clang --log > out/reference/kokoro_log --spmc > out/reference/secure_aem_v8a_fvp_clang/hafnium.bin --driver=fvp --hypervisor > out/reference/aem_v8a_fvp_clang/hafnium.bin --partitions_json > test/vmapi/ffa_secure_partitions/ffa_both_world_partitions_test.json > > > > The command line is from kokoro/test_spmc.sh. > > > > Thanks > > Raghu > > > > -- > Hafnium mailing list > Hafnium(a)lists.trustedfirmware.org > https://lists.trustedfirmware.org/mailman/listinfo/hafnium >

4 years

4
8
0 0

Hafnium toolchain switch

by Olivier Deprez

Hi, A small heads up that from this change: https://review.trustedfirmware.org/c/hafnium/hafnium/+/11613 a developer needs to provide the LLVM/clang toolchain through the PATH environment variable. See the documentation update: https://review.trustedfirmware.org/plugins/gitiles/hafnium/hafnium/+/HEAD/d… Until then the toolchain was hardcoded to use the version stored in the prebuilt submodule. >From now, this weakens the dependency to the prebuilt toolchain and provides flexibility with providing an alternate toolchain on a x86 host. This also opens to building on an aarch64 host. This has been tested with different combinations of hosts, ubuntu releases and toolchains downloaded from https://releases.llvm.org/download.html x86_64 Ubuntu 18.04 / 20.04 clang/llvm 12.0.0 , 13.0.0 aarch64 Ubuntu 19.04 (Ampere eMAG) / 20.04, 21.04 (Rpi4) clang/llvm 12.0.0 , 12.0.1, 13.0.0 It is still possible to point PATH to the prebuilt toolchain version (Android llvm/clang 12.0.5) as indicated in the documentation. If you have a live tree, please clean the out directory or run make clobber, once you update master. Builds run as before after the switch. Limitations: -the build breaks if using a native toolchain installed on the host (apt-get install clang..) -the build breaks with Ubuntu 21.10/AArch64 (under investigation). Regards, Olivier.

4 years

1
0
0 0

Re: [Hafnium] [TF-A] A problem about assert failed in TF-A

by Joanna Farley

TF-A List. This issue has also been discussed on Hafnium list before being posted here. Cross posting so we can have a single thread to track going forward. See https://lists.trustedfirmware.org/pipermail/hafnium/2021-December/000209.ht… with Olivier's last reply copied below. But see the archive above for full history of the thread. > Hi Wang, > > With this level of details; this is difficult to say. You can extend to the TF-A ML if you wish. I'm hinting the SPMD because you are mentioning spmd_smc_forward and cm_el1/2_sysregs_context_restore which are within the SPMD/EL3 space. I wouldn't expect such assert to happen in any regular use case of the reference implementation (because this is a hard EL3 failure). But yes, the problem can be elsewhere in Hafnium or Cactus, but I'd say less likely to alter the EL3 state. Unless Hafnium has a bug leading to corrupting a secure memory region which doesn't belong to it. > Beyond this, notice the assert is taken in cm_el1_sysregs_context_restore. It is called by cm_prepare_el3_exit which means it can be related to power management e.g. on a psci resume event. This can be a hint as you say this is occurring 'randomly'. > > Regards, > Olivier. Joanna On 14/12/2021, 19:39, "TF-A on behalf of Chenxu Wang via TF-A" <tf-a-bounces(a)lists.trustedfirmware.org on behalf of tf-a(a)lists.trustedfirmware.org> wrote: Hi all, I am running FVP with 2CPUs, Cactus SP (SEL1), Hafnium (SEL2) and KVM VHE. Sometimes I send the "FFA_MSG_SEND_DIRECT_REQ" smc call from KVM (I fill 0x8400006f in x0, then VMID and SP ID in x1, let x2 as 0). It says assert failed, like this: ASSERT: lib/el3_runtime/aarch64/context_mgmt.c:651 BACKTRACE: START: assert 0: EL3: 0x4005cac 1: EL3: 0x400323c 2: EL3: 0x400620c 3: EL3: 0x400e180 4: EL3: 0x4005a94 BACKTRACE: END: assert After I check the bl31.dump, I notice that: when services/std_svc/spmd/spmd_main.c sends the FFA call (from NS to S) via "spmd_smc_forward(smc_fid, secure_origin,x1, x2, x3, x4, handle)", it will go to cm_el1_sysregs_context_restore(secure_state_out) and cm_el2_sysregs_context_restore(secure_state_out), then it will assert the cm_get_context(). it gets the NULL context, so assert failed. Before the problem appeared, I have modified many codes on a dirty TF-A v2.4 (commit hash is 0aa70f4c4c023ca58dea2d093d3c08c69b652113), Hafnium and TF-A-TESTS. I also mail with Hafnium MailList, they consider it can be a problem in EL3. Such assert is NOT ALWAYS failed. I mean, maybe when I run FVP and send "smc" now, it is failed. But when I shut down, run FVP, and send the same instruction with the same parameter again, it is OK. I want to know, what is the possible reasons for suddenly losing the secure context. Can you give me some advice on debugging? e.g., where should I check? Need I provide more info? Sincerely, Wang -- TF-A mailing list TF-A(a)lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/tf-a

4 years

3
2
0 0

A problem about assert failed in TF-A

by Chenxu Wang

Hi all, I am running Hafnium on FVP, with Cactus SP in SEL1 and KVM VHE enabled. Sometimes I send the "FFA_MSG_SEND_DIRECT_REQ" smc call in KVM (I fill 0x8400006f in x0, then VMID and SP ID in x1, let x2 as 0). It says assert failed, like this: ASSERT: lib/el3_runtime/aarch64/context_mgmt.c:651 BACKTRACE: START: assert 0: EL3: 0x4005cac 1: EL3: 0x400323c 2: EL3: 0x400620c 3: EL3: 0x400e180 4: EL3: 0x4005a94 BACKTRACE: END: assert I notice that when services/std_svc/spmd/spmd_main.c sends the FFA call (from NS to S) via "spmd_smc_forward(smc_fid, secure_origin,x1, x2, x3, x4, handle)", it will go to cm_el1_sysregs_context_restore(secure_state_out) and cm_el2_sysregs_context_restore(secure_state_out), then it will assert the cm_get_context(). it gets the NULL context, so assert failed. Such assert is NOT ALWAYS failed, but I still want to solve this problem. Since I have modified many lines of code in Hafnium and Cactus SP, I cannot show them here. Can you give me some advice on debugging? e.g., where should I check?

4 years

2
5
0 0

Re: [Hafnium] Virtualising OP-TEE with Hafnium at S-EL2

by Olivier Deprez

Hi Xiangyi Xu For some reason your email was discarded by mailman, did you miss registering to the list? See few comments inline [OD] Regards, Olivier. ________________________________________ From: xiangyi xu <xuxiangyi666(a)gmail.com> Sent: 27 November 2021 14:13 To: hafnium(a)lists.trustedfirmware.org Subject: Virtualising OP-TEE with Hafnium at S-EL2 HI ALL: I am trying to setup Hafnium environment which loads OP-TEE in Security World and Linux in Normal World. I follow this instruction: https://lists.trustedfirmware.org/pipermail/hafnium/2021-January/000130.html. I can load the OP-TEE test successfully. But the BL33 payload is TF-A-tests example (BL33=../tf-a-tests/build/fvp/debug/tftf.bin). Could you share with us the tutorial to boot linux including the FF-A driver in the NS world while loading OP-TEE with Hafnium S-EL2? The presentation PPT is here: https://static.linaro.org/connect/lvc21/presentations/lvc21-305.pdf. [OD] The mentioned presentation is in context of the Total Compute platform (as opposed to FVP). It works great for what you want to do, and you can reproduce by following the user manual: https://gitlab.arm.com/arm-reference-solutions/arm-reference-solutions-docs… There is also work in progress at Linaro to provide a similar environment using the FVP. @Jens, are there public instructions on how to build the end to end scenario targeting the FVP incl. Linux, FF-A driver, TF-A, Hafnium, OP-TEE ? If not, I reckon this is in your mid term roadmap? Secondly, I can boot Linux with QEMU and Hafnium. But it seems Hafnium only supports NS world partition while using QEMU. Is any instruction to boot OP_TEE in Security world with Hafnium S-EL2. Since, QEMU 6.0 already supports S-EL2. However, I could not compile ATF successfully with SPD=spmd CTX_INCLUDE_EL2_REGS=1 PLAT=qemu ... [OD] qemu is not 'officially' supported for booting Hafnium at S-EL2. Although I have few changes in progress which may help. This is not a priority from Arm perspective, but let me come back on this. By following https://teaclave.apache.org/trustzone-sdk-docs/getting-started-with-optee-f… , I can boot Linux in NS and OP-TEE in Trustzone with QEMU, but it doesn't work when I add Hafnium. Thanks! Xiangyi Xu

4 years, 1 month

1
0
0 0

How to allow Hafnium to access a DRAM address space

by Chenxu Wang

Hi all, I try to use Hafnium (deployed in SEL2) to access a DRAM address, e.g. 0xa000_0000, but failed. I think the TTBR0_EL2 does not map this address space, or something wrong with TZASC. To solve this problem, I first add the DRAM region in TZASC and TTBR0_EL3 (by modifying TF-A), and EL3 can access this address. But Hafnium cannot read or write it. So, must I modify the .S files in Hafnium to add a page mapping to the DRAM space? Can I add this page in some C files? Or should I do something else? Sincerely, Wang Chenxu

4 years, 2 months

2
3
0 0

TF-A Tech Forum Agenda: Thu 12th August 2021 16:00 – 17:00 (BST)

by Joanna Farley

Hi All, The next TF-A Tech Forum is scheduled for Thu 12th August 2021 16:00 – 17:00 (BST). Agenda: * Enabling S-EL0 FF-A partitions on Hafnium using ARMv8.1 FEAT_VHE – Presented by Raghupathy Krishnamurthy * Summary: Present and discuss enabling S-EL0 FF-A partitions on Hafnium using ARMv8.1 FEAT_VHE. The goal is to present an ARM server centric view point on the requirements in Secure World, the solution space explored to meet these requirements and why/how FF-A S-EL0 partition on hafnium using FEAT_VHE appear to fit these requirements. If TF-A contributors have anything they wish to present at any future TF-A tech forum please contact me to have that scheduled. Previous sessions, both recording and presentation material can be found on the trustedfirmware.org TF-A Technical meeting webpage: https://www.trustedfirmware.org/meetings/tf-a-technical-forum/ A scheduling tracking page is also available to help track sessions suggested: https://developer.trustedfirmware.org/w/tf_a/tf-a-tech-forum-scheduling/ Final decisions on what will be presented will be shared a few days before the next meeting on the TF-A mailing list. You have been invited to the following event. TF-A Tech Forum When Every 2 weeks from 16:00 to 17:00 on Thursday United Kingdom Time Calendar tf-a(a)lists.trustedfirmware.org Who • Bill Fletcher- creator • tf-a(a)lists.trustedfirmware.org more details »<https://www.google.com/calendar/event?action=VIEW&eid=NWlub3Ewdm1tMmk1cTJrM…> We run an open technical forum call for anyone to participate and it is not restricted to Trusted Firmware project members. It will operate under the guidance of the TF TSC. Feel free to forward this invite to colleagues. Invites are via the TF-A mailing list and also published on the Trusted Firmware website. Details are here: https://www.trustedfirmware.org/meetings/tf-a-technical-forum/<https://www.google.com/url?q=https%3A%2F%2Fwww.trustedfirmware.org%2Fmeetin…> Trusted Firmware is inviting you to a scheduled Zoom meeting. Join Zoom Meeting https://zoom.us/j/9159704974<https://www.google.com/url?q=https%3A%2F%2Fzoom.us%2Fj%2F9159704974&sa=D&us…> Meeting ID: 915 970 4974 One tap mobile +16465588656,,9159704974# US (New York) +16699009128,,9159704974# US (San Jose) Dial by your location +1 646 558 8656 US (New York) +1 669 900 9128 US (San Jose) 877 853 5247 US Toll-free 888 788 0099 US Toll-free Meeting ID: 915 970 4974 Find your local number: https://zoom.us/u/ad27hc6t7h<https://www.google.com/url?q=https%3A%2F%2Fzoom.us%2Fu%2Fad27hc6t7h&sa=D&us…> Going (tf-a(a)lists.trustedfirmware.org)? All events in this series: Yes<https://www.google.com/calendar/event?action=RESPOND&eid=NWlub3Ewdm1tMmk1cT…> - Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=NWlub3Ewdm1tMmk1cT…> - No<https://www.google.com/calendar/event?action=RESPOND&eid=NWlub3Ewdm1tMmk1cT…> more options »<https://www.google.com/calendar/event?action=VIEW&eid=NWlub3Ewdm1tMmk1cTJrM…> Invitation from Google Calendar<https://www.google.com/calendar/> You are receiving this courtesy email at the account tf-a(a)lists.trustedfirmware.org because you are an attendee of this event. To stop receiving future updates for this event, decline this event. Alternatively, you can sign up for a Google Account at https://www.google.com/calendar/ and control your notification settings for your entire calendar. Forwarding this invitation could allow any recipient to send a response to the organiser and be added to the guest list, invite others regardless of their own invitation status or to modify your RSVP. Learn more<https://support.google.com/calendar/answer/37135#forwarding>. Thanks Joanna

4 years, 4 months

1
0
0 0

Re: [Hafnium] Bug in hftest.py

by Olivier Deprez

Hi Raghu, Thanks for reporting. This part of the test infrastructure (testing the SPMC) is still very fresh and requires improvement iterations so please bear with us. Also a reason it's not yet part of the automated non-regression with jenkins (as opposed to the legacy kokoro/test.sh). For the time being we still mostly rely on the TF-A CI for testing on the secure side. IIUC this change was made to help with the test time as the FVP takes long to reload on every test. But indeed it might have the side effect you describe. So either we revert the FVP reloading on every test. Or another (somewhat hackish) possibility is to clear the mentioned variables from within the test (or make them part of BSS)? To be fair, the both worlds test scenario is not 100% stable on my machine (for some reason the connection is not always successful between the FVP and hftest) hence limiting confidence/robustness of my testing and investigations. So I wonder is the scripting is still somewhat a bit fragile. Regards, Olivier. ________________________________________ From: Hafnium <hafnium-bounces(a)lists.trustedfirmware.org> on behalf of Raghu Krishnamurthy via Hafnium <hafnium(a)lists.trustedfirmware.org> Sent: 03 August 2021 23:47 To: 'Raghu Krishnamurthy via Hafnium' Subject: [Hafnium] Bug in hftest.py Hi All, Wanted to report to you that commit 18a25f9241f86ba2d637011ff465ce3869e8651b in hafnium "appears" broken. The issue with the optimization in this patch is that the partition images are not reloaded for each test run, which means a previous test could have written data to say SRAM, and the following test would use the old values from the previous test, when the same image is executed again from SRAM for a following test. This would be a problem for pretty much anything in the data section of a partition. In my case, I have a counter in the data section of my partition, which does not get reset back to its original value. I've attached a patch to help repro the issue. Fix is to disable the optimization or somehow reload the images for each run. This affects only "both world" tests. Let me know if I'm missing something here. Apply patch and run timeout --foreground 300s ./test/hftest/hftest.py --out_partitions out/reference/secure_aem_v8a_fvp_vm_clang --log out/reference/kokoro_log --spmc out/reference/secure_aem_v8a_fvp_clang/hafnium.bin --driver=fvp --hypervisor out/reference/aem_v8a_fvp_clang/hafnium.bin --partitions_json test/vmapi/ffa_secure_partitions/ffa_both_world_partitions_test.json The command line is from kokoro/test_spmc.sh. Thanks Raghu -- Hafnium mailing list Hafnium(a)lists.trustedfirmware.org https://lists.trustedfirmware.org/mailman/listinfo/hafnium

4 years, 4 months

2
1
0 0

Bug in hftest.py

by raghu.ncstate＠icloud.com

Hi All, Wanted to report to you that commit 18a25f9241f86ba2d637011ff465ce3869e8651b in hafnium "appears" broken. The issue with the optimization in this patch is that the partition images are not reloaded for each test run, which means a previous test could have written data to say SRAM, and the following test would use the old values from the previous test, when the same image is executed again from SRAM for a following test. This would be a problem for pretty much anything in the data section of a partition. In my case, I have a counter in the data section of my partition, which does not get reset back to its original value. I've attached a patch to help repro the issue. Fix is to disable the optimization or somehow reload the images for each run. This affects only "both world" tests. Let me know if I'm missing something here. Apply patch and run timeout --foreground 300s ./test/hftest/hftest.py --out_partitions out/reference/secure_aem_v8a_fvp_vm_clang --log out/reference/kokoro_log --spmc out/reference/secure_aem_v8a_fvp_clang/hafnium.bin --driver=fvp --hypervisor out/reference/aem_v8a_fvp_clang/hafnium.bin --partitions_json test/vmapi/ffa_secure_partitions/ffa_both_world_partitions_test.json The command line is from kokoro/test_spmc.sh. Thanks Raghu

4 years, 5 months

1
0
0 0

Re: [Hafnium] Hafnium - Memory attributes precedence checks for mem share

by Joao Alves

Hi Andrew, I don't think Hafnium implements the different cacheability and shareability types for memory sharing at all does it? [JA] No, it doesn't. At least that is my understanding as well. I noticed mostly due to lack of support in the mm library. Asking was a means to confirm. The point (at least for now) was just about validation of the respective fields in the memory transaction descriptor. Thank you for this! 🙂 Best regards, João ________________________________ From: Andrew Walbran Sent: Wednesday, July 14, 2021 5:29 PM To: Joao Alves Cc: hafnium(a)lists.trustedfirmware.org; Olivier Deprez; Achin Gupta; Mahesh Reddy Bireddy; Jaykumar Pitambarbhai Patel Subject: Re: Hafnium - Memory attributes precedence checks for mem share I don't think Hafnium implements the different cacheability and shareability types for memory sharing at all does it? We just didn't have a need for it, if you want to add support that should be fine. This is mentioned in https://developer.trustedfirmware.org/T827, you can assign that to yourself if you want to take it on. On Wed, 14 Jul 2021 at 13:50, Joao Alves <Joao.Alves(a)arm.com<mailto:Joao.Alves@arm.com>> wrote: Hi Andrew, We have been revising some aspects of the memory sharing implementation. The specification describes a set of precedence rules for the memory attributes specified in the memory transaction descriptor, including: Memory type, cacheability, shareability. The sender would fill the memory attributes for the region to be shared. After memory send, the receiver should retrieve the regions, filling the memory attributes on its transaction descriptor that comply with the referred precedence rules. The referred rules can be found in section 10.10.4 of the newly release FF-A v1.1 beta spec<https://developer.arm.com/documentation/den0077/c/?lang=en>, as follows. Memory type precedence rules ( < reads as is less permissive than): * Device-nGnRnE < Device-nGnRE < Device-nGRE < Device-GRE < Normal Cacheability precedence rules: * Non-cacheable < Write-Back Cacheable Shareability precedence rules: * Non-Shareable < Inner Shareable < Outer shareable These checks are not part of the handling of FFA_MEMORY_RETRIEVE_REQ. Was there an implementation defined reason for this? If so, could you please provide the rationale? Thank you in advance for your help. Best regards, João Alves

4 years, 5 months

1
0
0 0

2026

2025

2024

2023

2022

2021

2020

Hafnium