Hi all,
Thank you for the quick replies.
I agree that patches should be reviewable – I will try to keep them this way.
Here is the first one for some of the violations in header files -
https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/47366
Best regards,
Bohdan Hunko
Cypress Semiconductor Ukraine LLC
Senior Engineer
CSS ICW SW INT BFS SFW
Mobile: +380995019714
Bohdan.Hunko@infineon.com
From: Nicola Mazzucato <Nicola.Mazzucato@arm.com>
Sent: Tuesday, 20 January 2026 13:26
To: tf-m@lists.trustedfirmware.org; Hunko Bohdan (CSS ICW SWE INT BFS SFW) <Bohdan.Hunko@infineon.com>
Cc: Kytsun Hennadiy (CSS ICW SWE INT BFS SFW) <Hennadiy.Kytsun@infineon.com>
Subject: Re: Upstreaming of MISRA fixes
|
Caution: This e-mail originated outside Infineon
Technologies. Please be cautious when sharing information or opening attachments especially from unknown senders. Refer to our intranet
guide to help you identify Phishing email. |
Hi Bohdan,
May I suggest to push the patches in small changes to ease review and then perhaps squash some of them? Maybe we can attempt to organize them across categories or rules? Essentially
I understand the intent and suggesting a way in between if possible.
Thanks
Nick
From: Bohdan.Hunko--- via TF-M <tf-m@lists.trustedfirmware.org>
Sent: 20 January 2026 11:10
To: tf-m@lists.trustedfirmware.org <tf-m@lists.trustedfirmware.org>
Cc: Hennadiy.Kytsun@infineon.com <Hennadiy.Kytsun@infineon.com>
Subject: [TF-M] Upstreaming of MISRA fixes
Hi,
In our local copy of TFM we are running Coverity tools which performs MISRA, CERT-C and CODING static analysis checks on TFM codebase (I will refer to this as MISRA
fixes for simplicity). During our development we did a bunch of fixes for the violations (not all rules but still significant number of changes). Most of these changes are small (e.g. U/UL postfixes, fixed width types usage, header file fixes etc…).
When we do version updates or generally port code between upstream and local copy of TFM we have to deal with merge conflicts in these lines effected by MISRA fixes.
To avoid these issues we would like to push these fixes upstream.
There are quite a few changes and having everything in one patch will really simplify our work as we would not have to divide the changes.
We would like to know whether creating one bigger patch with all the changes would be acceptable for the review?
Best regards,
Bohdan Hunko
Cypress Semiconductor Ukraine LLC
Senior Engineer
CSS ICW SW INT BFS SFW
Mobile: +380995019714
Bohdan.Hunko@infineon.com