Hi Anton, Ken,

It is a good idea to increase the line limit.

I’d prefer to keep a single line limit in TF-M. Multiple limits may not be a good practice.

Can I suggest to set the limit to 100 chars right now, to fit both SPM and non-SPM part?

Besides, in non-SPM part, exceptions can be accepted for 128 chars.

Best regards,

Hu Ziji

From: Ken Liu via TF-M <tf-m@lists.trustedfirmware.org>
Sent: Tuesday, August 2, 2022 7:16 PM
To: tf-m@lists.trustedfirmware.org
Cc: nd <nd@arm.com>
Subject: [TF-M] Re: Proposal for coding standard update: Increase chars per line 80-> 128.

No objections to making it a common guideline.

But I’d like to require SPM code to be in 80 as possible it could when review (In review comments) – as SPM contains some delicate logic, 80 columns would provide a better view in Gerrit to help the review.

/Ken

From: Anton Komlev via TF-M <tf-m@lists.trustedfirmware.org>
Sent: Tuesday, August 2, 2022 6:17 PM
To: tf-m@lists.trustedfirmware.org
Cc: nd <nd@arm.com>
Subject: [TF-M] Proposal for coding standard update: Increase chars per line 80-> 128.

Hi,

TF-M coding standard mandates up to 80 characters per line. This looks a bit too restrictive nowadays with no punch cards or text terminals.

I propose to increase this limit to 120 or 140 characters. Personally like 128.

Are there any thoughts or objections against it?

Thanks,

Anton