Hi Thomas,

The tf-m-tests fix is under review and has not been merged yet. Therefore that commit ID is not available in tf-m-tests.

I'd suggest to do following to test the fix:
After the fix is merged, the commit will be available when fetching the tf-m-tests repo.

Best regards,
Hu Ziji

From: Thomas Törnblom <thomas.tornblom@iar.com>
Sent: Thursday, November 18, 2021 8:10 PM
To: David Hu <David.Hu@arm.com>; David Wang <David.Wang@arm.com>; Feder Liang <Feder.Liang@arm.com>
Cc: nd <nd@arm.com>
Subject: Re: [TF-M] d4dbaa93, "Add FPU support for gnu arm embedded toolchain" causing build errors
 
I'm getting another error after cherry picking these:

PS D:\Projects\trusted-firmware-m\iar> cmake -GNinja -S .. -B . -DTFM_PLATFORM=arm/musca_s1 "-DTFM_TOOLCHAIN_FILE=..\toolchain_IARARM.cmake"  -DTEST_NS=ON -DTEST_S=ON -DCMAKE_BUILD_TYPE=Debug -DBL2=ON -DTEST_NS_QCBOR=OFF
-- Populating tfm_test_repo
-- Configuring done
-- Generating done
-- Build files have been written to: D:/Projects/trusted-firmware-m/iar/lib/ext/tfm_test_repo-subbuild
[1/9] Creating directories for 'tfm_test_repo-populate'
[1/9] Performing download step (git clone) for 'tfm_test_repo-populate'
Cloning into 'tfm_test_repo-src'...
remote: Enumerating objects: 1094, done.
remote: Counting objects: 100% (1094/1094), done.
remote: Compressing objects: 100% (613/613), done.
remote: Total 2057 (delta 913), reused 511 (delta 481), pack-reused 963
Receiving objects: 100% (2057/2057), 2.05 MiB | 8.43 MiB/s, done.
Resolving deltas: 100% (1371/1371), done.
fatal: invalid reference: 14ca288
CMake Error at tfm_test_repo-subbuild/tfm_test_repo-populate-prefix/tmp/tfm_test_repo-populate-gitclone.cmake:40 (message):
  Failed to checkout tag: '14ca288'


FAILED: tfm_test_repo-populate-prefix/src/tfm_test_repo-populate-stamp/tfm_test_repo-populate-download
cmd.exe /C "cd /D D:\Projects\trusted-firmware-m\iar\lib\ext && "C:\Program Files\CMake\bin\cmake.exe" -P D:/Projects/trusted-firmware-m/iar/lib/ext/tfm_test_repo-subbuild/tfm_test_repo-populate-prefix/tmp/tfm_test_repo-populate-gitclone.cmake && "C:\Program Files\CMake\bin\cmake.exe" -E touch D:/Projects/trusted-firmware-m/iar/lib/ext/tfm_test_repo-subbuild/tfm_test_repo-populate-prefix/src/tfm_test_repo-populate-stamp/tfm_test_repo-populate-download"
ninja: build stopped: subcommand failed.
CMake Error at C:/Program Files/CMake/share/cmake-3.20/Modules/FetchContent.cmake:1012 (message):
  Build step for tfm_test_repo failed: 1
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.20/Modules/FetchContent.cmake:1141:EVAL:2 (__FetchContent_directPopulate)
  C:/Program Files/CMake/share/cmake-3.20/Modules/FetchContent.cmake:1141 (cmake_language)
  lib/ext/tf-m-tests/fetch_repo.cmake:27 (FetchContent_Populate)
  lib/ext/tf-m-tests/tf-m-tests.cmake:56 (include)
  config/set_config.cmake:68 (include)
  CMakeLists.txt:42 (include)


Den 2021-11-18 kl. 13:00, skrev David Hu:

Hi Thomas,

 

Sorry for the failure and the trouble.

The build logic of QCBOR NS test was adjusted to fit FP feature but the logic has defect when QCBOR NS test = OFF.

Please cherry pick the following 2 patches and have a try:

https://review.trustedfirmware.org/c/TF-M/tf-m-tests/+/12563

https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/12564

 

The fix will be port back to master branch when release completes.

 

Best regards,

Hu Ziji

 

From: TF-M <tf-m-bounces@lists.trustedfirmware.org> On Behalf Of Thomas Törnblom via TF-M
Sent: Thursday, November 18, 2021 6:57 PM
To: David Wang <David.Wang@arm.com>; Feder Liang <Feder.Liang@arm.com>
Cc: nd <nd@arm.com>; tf-m@lists.trustedfirmware.org
Subject: Re: [TF-M] d4dbaa93, "Add FPU support for gnu arm embedded toolchain" causing build errors

 

Oh, and it fails the same on Windows and linux, as well as ARMCLANG and IARARM.

/Thomas

Den 2021-11-18 kl. 11:56, skrev Thomas Törnblom:

commit fd88f7fbde4d23720c3c9be7350e628df51ef964 (HEAD -> master, tag: TF-Mv1.5.0-RC1, origin/master, origin/HEAD, list)

Den 2021-11-18 kl. 11:27, skrev David Wang:

Hi Thomas,

Could you share the SHA of your branch HEAD?

Or you can try to fetch the latest tag and code.

 

Regards,

David Wang

 

From: TF-M <tf-m-bounces@lists.trustedfirmware.org> On Behalf Of Thomas Törnblom via TF-M
Sent: Thursday, November 18, 2021 6:10 PM
To: Feder Liang <Feder.Liang@arm.com>
Cc: nd <nd@arm.com>; tf-m@lists.trustedfirmware.org
Subject: Re: [TF-M] d4dbaa93, "Add FPU support for gnu arm embedded toolchain" causing build errors

 

Nope,

I was using "master", which was 1.5.0 RC1, both fails.

/Thomas

Den 2021-11-18 kl. 10:56, skrev Feder Liang:

Hi, Thomas

 

It seems TF-M and Test repo is not synced.

Could you help a try on latest TF-M master branch or tag: TF-Mv1.5.0-RC1?

 

Best Regards

Feder

 

From: TF-M <tf-m-bounces@lists.trustedfirmware.org> On Behalf Of Thomas Törnblom via TF-M
Sent: Thursday, November 18, 2021 5:42 PM
To: tf-m@lists.trustedfirmware.org
Subject: [TF-M] d4dbaa93, "Add FPU support for gnu arm embedded toolchain" causing build errors

 

Looks like this patch is causing build errors, at least for Musca S1.

cmake line:
cmake -GNinja -S .. -B . -DTFM_PLATFORM=arm/musca_s1 "-DTFM_TOOLCHAIN_FILE=..\toolchain_ARMCLANG.cmake"  -DTEST_NS=ON -DTEST_S=ON -DCMAKE_BUILD_TYPE=Debug -DBL2=ON -DTEST_NS_QCBOR=OFF

[1233/1238] Linking C executable bin\tfm_ns.axf
FAILED: bin/tfm_ns.axf
cmd.exe /C "cd . && D:\apps\Keil_v5\ARM\ARMCLANG\bin\armlink.exe --cpu=cortex-m33 --info=summarysizes,sizes,totals,unused,veneers --strict --symbols --xref --diag_suppress=6312 --diag_suppress=6314 --diag_suppress=6304 --diag_suppress=6329 --fpu=softvfp --map --scatter=D:/Projects/trusted-firmware-m/armclang/platform/target/CMakeFiles/tfm_ns_scatter.dir/./Device/Source/armclang/musca_ns.o  platform\libplatform_ns.a  app\libtfm_ns_integration_test.a  app\libtfm_api_ns.a  ns_log\libtfm_ns_log.a  test\suites\core\libtfm_test_suite_core_ns.a  app\libtfm_ns_integration_test.a  test\suites\core\libtfm_test_suite_core_ns.a  test\suites\attestation\libtfm_test_suite_attestation_ns.a  test\suites\crypto\libtfm_test_suite_crypto_ns.a  test\suites\qcbor\libtfm_test_suite_qcbor_ns.a  -ltfm_qcbor_test  test\suites\ps\libtfm_test_suite_ps_ns.a  test\suites\its\libtfm_test_suite_its_ns.a  test\suites\t_cose\libtfm_test_suite_t_cose_ns.a  test\suites\t_cose\libtfm_t_cose_test.a  test\suites\t_cose\libtfm_t_cose_ns.a  test\suites\qcbor\libtfm_qcbor_ns.a  test\suites\platform\libtfm_test_suite_platform_ns.a  test\suites\ipc\libtfm_test_suite_ipc_ns.a  lib\ext\tfm_test_repo-src\CMSIS\RTOS2\RTX\Library\ARM\RTX_V8MMN.lib  app\libtfm_api_ns.a  secure_fw\libtfm_s_veneers.a  ns_log\libtfm_ns_log.a  platform\libplatform_ns.a app\CMakeFiles\tfm_ns.dir\main_ns.o app\CMakeFiles\tfm_ns.dir\__\__\platform\ext\target\arm\musca_s1\Device\Source\armclang\startup_cmsdk_musca_ns.o app\CMakeFiles\tfm_ns.dir\__\ns_interface\ns_client_ext\tz_shim_layer.o app\CMakeFiles\tfm_ns.dir\__\CMSIS\RTOS2\RTX\Config\RTX_Config.o app\CMakeFiles\tfm_ns.dir\__\CMSIS\RTOS2\RTX\Source\rtx_lib.o app\CMakeFiles\tfm_ns.dir\os_wrapper_cmsis_rtos_v2.o -o bin\tfm_ns.axf  --list=bin\tfm_ns.axf.map && cd ."
Fatal error: L3900U: Unrecognized option '-ltfm_qcbor_test'.
Finished: 0 information, 0 warning, 0 error and 1 fatal error messages.
ninja: build stopped: subcommand failed.

--

Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems

 

--

Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems

 

--

Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems

 

--

Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems


--

Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems