Hi Thomas,
The flash image rearrangement should not impact the ITS/PS area. The start address of ITS/PS area remains the same.
I tested it on nxp/ lpcxpresso55s69 with
“cmake -S . -B nxp_build_before -DTFM_PLATFORM=nxp/lpcxpresso55s69 -DTEST_NS=ON -DTEST_S=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBL2=OFF” based on 3a0e46 which is the commit before flash layout rearrangement. The test passed. And then I
downloaded the image which is built with the same configuration based on 3afa64(the flash layout rearrangement commit) without erasing the flash. The test passed again.
Also tested following the same procedure on musca_b1 board. The issue is not reproduced on my local. I used armclang version 6.16 and gcc version 9.2.1.
Sorry, I cannot reproduce it on my local. Thanks for checking further.
Regards,
Sherry Zhang
From: Thomas Törnblom <thomas.tornblom@iar.com>
Sent: Tuesday, January 4, 2022 12:46 PM
To: Sherry Zhang <Sherry.Zhang2@arm.com>
Cc: tf-m@lists.trustedfirmware.org; nd <nd@arm.com>
Subject: Re: [TF-M] Re: Some broken builds
Hi Sherry,
I don’t think it is a HW issue as I got similar issues on the lpcxpresso55s69.
I guess it could be garbage in the flash that didn’t get cleared properly after the flash image rearrangement.
I’ll check further today.
Cheers,
Thomas
4 jan. 2022 kl. 03:14 skrev Sherry Zhang <Sherry.Zhang2@arm.com>:
Hi Thomas,
ITS/PS_RAM_FS is not mandatory to make the tests pass. I tested the latest master branch(hash a7ba50ba1ca417e4426eb840b855f3003c7f9e28) with
“cmake -S . -B cmake_build -DTFM_PLATFORM=arm/musca_b1/sse_200 -DTFM_TOOLCHAIN_FILE=toolchain_ARMCLANG.cmake -DTEST_NS=ON -DTEST_S=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBL2=ON”
I run the image locally on musca_b1 board. All the tests passed.
Also the tests on musca_b1/sse_200 is covered by nightly CI. No error is reported by the last night’s CI(https://ci.trustedfirmware.org/view/TF-M/job/tf-m-nightly/790/).
Maybe there is something wrong with the flash on your local musca_b1 board. Can you erase the flash and try again with ITS/PS_RAM_FS=OFF?
Regards,
Sherry Zhang
From: Thomas Törnblom via TF-M <tf-m@lists.trustedfirmware.org>
Sent: Monday, January 3, 2022 11:00 PM
To: tf-m@lists.trustedfirmware.org
Subject: [TF-M] Re: Some broken builds
Nm, missed -DITS_RAM_FS=ON -DPS_RAM_FS=ON.
Works with that.
ThomasDen 2022-01-03 kl. 13:28, skrev Thomas Törnblom:
Back after the holidays I have tested a few builds and I've noticed that a few builds fail a bunch of tests.
Fails on all tool chains.
Is this a known issue?
psoc64, musca_s1 works.
Musca_B1 (nxp lpcxpresso55s69 also fails:
PS D:\Projects\tf-m6\trusted-firmware-m\armclang> cmake -GNinja -S .. -B . -DTFM_PLATFORM=arm/musca_b1/sse_200 "-DTFM_TOOLCHAIN_FILE=..\toolchain_ARMCLANG.cmake" -DTEST_NS=ON -DTEST_S=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBL2=ON
...
Running Test Suite PSA internal trusted storage S interface tests (TFM_S_ITS_TEST_1XXX)...
> Executing 'TFM_S_ITS_TEST_1001'
Description: 'Set interface'
Set should not fail with valid UID (Failed at D:/Projects/tf-m6/trusted-firmware-m/armclang/lib/ext/tfm_test_repo-src/test/suites/its/its_tests_common.c:32)
TEST: TFM_S_ITS_TEST_1001 - FAILED!
> Executing 'TFM_S_ITS_TEST_1002'
Description: 'Set interface with create flags'
Set should not fail with no flags (Failed at D:/Projects/tf-m6/trusted-firmware-m/armclang/lib/ext/tfm_test_repo-src/test/suites/its/its_tests_common.c:91)
TEST: TFM_S_ITS_TEST_1002 - FAILED!
> Executing 'TFM_S_ITS_TEST_1003'
Description: 'Set interface with NULL data pointer'
Set should succeed with NULL data pointer and zero length (Failed at D:/Projects/tf-m6/trusted-firmware-m/armclang/lib/ext/tfm_test_repo-src/test/suites/its/its_tests_common.c:115)
TEST: TFM_S_ITS_TEST_1003 - FAILED!
> Executing 'TFM_S_ITS_TEST_1004'
Description: 'Set interface with write once UID'
Set should not rewrite a write once UID (Failed at D:/Projects/tf-m6/trusted-firmware-m/armclang/lib/ext/tfm_test_repo-src/test/suites/its/its_tests_common.c:138)
TEST: TFM_S_ITS_TEST_1004 - FAILED!
> Executing 'TFM_S_ITS_TEST_1005'
Description: 'Get interface with valid data'
Set should not fail (Failed at D:/Projects/tf-m6/trusted-firmware-m/armclang/lib/ext/tfm_test_repo-src/test/suites/its/its_tests_common.c:186)
TEST: TFM_S_ITS_TEST_1005 - FAILED!
> Executing 'TFM_S_ITS_TEST_1006'
Description: 'Get interface with zero data length'
Set should not fail (Failed at D:/Projects/tf-m6/trusted-firmware-m/armclang/lib/ext/tfm_test_repo-src/test/suites/its/its_tests_common.c:293)
TEST: TFM_S_ITS_TEST_1006 - FAILED!
...
(lots more failed tests)
...
*** Non-secure test suites summary ***
Test suite 'PSA protected storage NS interface tests (TFM_NS_PS_TEST_1XXX)' has PASSED
Test suite 'PSA internal trusted storage NS interface tests (TFM_NS_ITS_TEST_1XXX)' has FAILED
Test suite 'Crypto non-secure interface test (TFM_NS_CRYPTO_TEST_1XXX)' has FAILED
Test suite 'Platform Service Non-Secure interface tests(TFM_NS_PLATFORM_TEST_1XXX)' has PASSED
Test suite 'Initial Attestation Service non-secure interface tests(TFM_NS_ATTEST_TEST_1XXX)' has PASSED
Test suite 'QCBOR regression test(TFM_NS_QCBOR_TEST_1XXX)' has PASSED
Test suite 'T_COSE regression test(TFM_NS_T_COSE_TEST_1XXX)' has PASSED
Test suite 'PSA firmware update NS interface tests (TFM_NS_FWU_TEST_1xxx)' has PASSED
Test suite 'Core non-secure positive tests (TFM_NS_CORE_TEST_1XXX)' has PASSED
Test suite 'IPC non-secure interface test (TFM_NS_IPC_TEST_1XXX)' has PASSED
Test suite 'TFM IRQ Test (TFM_IRQ_TEST_1xxx)' has PASSED
*** End of Non-secure test suites ***
--
Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems
--
Thomas Törnblom, Product Engineer
IAR Systems AB
Box 23051, Strandbodgatan 1
SE-750 23 Uppsala, SWEDEN
Mobile: +46 76 180 17 80 Fax: +46 18 16 78 01
E-mail: thomas.tornblom@iar.com Website: www.iar.com
Twitter: www.twitter.com/iarsystems