Hi Manish,

Sure . I will submit a patch for this .

Regards

Amit

From: Manish Badarkhe <Manish.Badarkhe@arm.com>

Sent: Tuesday, October 3, 2023 4:30 PM

To: Nagal, Amit <amit.nagal@amd.com>; tf-a@lists.trustedfirmware.org

Subject: Re: #ifdef PLAT_XLAT_TABLES_DYNAMIC in xlat_tables_context.c

Hi Amit

Sorry for delay in reply.

It looks like you have found the bug. Could you please create a patch for this and post it for review?

In the meantime, we are investigating to avoid such kinds of bugs. Preferably, we should/must use #if wherever possible.

Regards,

Manish Badarkhe

From: Nagal, Amit via TF-A <mailto:tf-a@lists.trustedfirmware.org>

Date: Friday, 22 September 2023 at 06:37

To: mailto:tf-a@lists.trustedfirmware.org <mailto:tf-a@lists.trustedfirmware.org>

Subject: [TF-A] #ifdef PLAT_XLAT_TABLES_DYNAMIC in xlat_tables_context.c

Hi ,

When I grep for PLAT_XLAT_TABLES_DYNAMIC in /lib/lib/xlat_tables_v2/ ,

I see most references for PLAT_XLAT_TABLES_DYNAMIC are enclosed in #if directive.

Is there any specific reason why only below mentioned reference for PLAT_XLAT_TABLES_DYNAMIC

is covered with #ifdef and not under #if .

https://github.com/Xilinx/arm-trusted-firmware/blob/master/lib/xlat_tables_v2/xlat_tables_context.c#L203

#ifdef PLAT_XLAT_TABLES_DYNAMIC

#define MAX_PHYS_ADDR tf_xlat_ctx.pa_max_address

#else

#define MAX_PHYS_ADDR tf_xlat_ctx.max_pa

#endif

Regards

Amit

TF-A mailing list -- mailto:tf-a@lists.trustedfirmware.org

To unsubscribe send an email to mailto:tf-a-leave@lists.trustedfirmware.org