Hi Marchin, 

Will take this patch for the release.

To answer Leif's question,

The reason for this was to ensure that a fixed platform does not miss on a mandatory feature just because the firmware integrator forgets to enable it. This makes the life easier for integrator and at the same time avoids any programming mistake.

For variable platforms like (FVP etc) the best way is to keep all features to be dynamically detected.

Thanks
Manish
From: Marcin Juszkiewicz via TF-A <tf-a@lists.trustedfirmware.org>
Sent: 13 November 2023 18:16
To: Andre Przywara <Andre.Przywara@arm.com>; Marcin Juszkiewicz via TF-A <tf-a@lists.trustedfirmware.org>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Jean-Philippe Brucker <jean-philippe@linaro.org>; Govindraj Raja <Govindraj.Raja@arm.com>
Subject: [TF-A] Re: We cannot force Arm features for platforms
 
W dniu 13.11.2023 o 18:55, Marcin Juszkiewicz pisze:
> W dniu 13.11.2023 o 18:23, Andre Przywara pisze:
>
>> But using runtime checking for flexible platforms  was the plan all
>> along. We did the groundwork for the FVP, feature by feature, check
>> commit
>> 6503ff2910ae5ed for an example. For all flexible platforms, the idea is
>> that the default architecture revision stays at v8.0 (to cover "-cpu
>> cortex-a57", for instance), but all(?) features get promoted to a runtime
>> check (=2). Check the current version of plat/arm/board/fvp/platform.mk.
>>
>> The same problem hits the Arm FPGA, which is a very simple platform
>> sporting the newest cores in development. Check commit b321c243423b93,
>> which enabled all relevant features to do a runtime check.
>>
>> So please just push a patch similar to that, and we should be good?
>
> Thanks for suggestion. Looks like you went with reverse approach then is
> present for qemu platforms.
>
> I tried your approach. Made v8.0 default and then enabled all v8.1-v8.7
> flags as 'check at runtime'. Quick check shown that Linux boots fine on
> A57/N1/V1/max.
>
> Will send patch once my testing script finish and I compare results.

https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/24870 is
the result.

Tested with BSA/SBSA ACS and Debian Linux 6.5 kernel. No visible changes.
--
TF-A mailing list -- tf-a@lists.trustedfirmware.org
To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org