Haojian,

As project Code Owner for this area and the HiSilicon platform that makes use of this can you provide the initial review? General code reviews and Maintainer reviews can then follow.

Thanks

Joanna

From: TF-A <tf-a-bounces@lists.trustedfirmware.org> on behalf of Jorge Troncoso via TF-A <tf-a@lists.trustedfirmware.org>
Reply to: Jorge Troncoso <jatron@google.com>
Date: Monday, 4 October 2021 at 16:01
To: "tf-a@lists.trustedfirmware.org" <tf-a@lists.trustedfirmware.org>, Soby Mathew <Soby.Mathew@arm.com>, Louis Mayencourt <Louis.Mayencourt@arm.com>, John Stultz <john.stultz@linaro.org>, Haojian Zhuang <haojian.zhuang@linaro.org>, John Powell <John.Powell@arm.com>, Anand Saminathan <anans@google.com>
Subject: Re: [TF-A] [RFC]: UFS patches

Hello! Gentle reminder, can I get code review for the patches linked above?

On Fri, Oct 1, 2021 at 8:00 AM Jorge Troncoso <jatron@google.com> wrote:

Hi all,

We made a few changes to the UFS driver. The proposed patches are posted here: https://review.trustedfirmware.org/q/topic:%22ufs_patches%22+(status:open%20OR%20status:merged).

The patches mainly consist of the below changes:

1. Delete asserts. Return error values instead.
2. Add retry logic and timeouts.
3. Reuse ufshc_send_uic_cmd() for DME_GET and DME_SET commands.

Any feedback/comments on these patches would be greatly appreciated.

Thanks!

Jorge Troncoso