Hi,
Please find the latest report on new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
5 new defect(s) introduced to ARM-software/arm-trusted-firmware found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)
** CID 395330: Code maintainability issues (UNUSED_VALUE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 182 in get_clk_freq()
________________________________________________________________________________________________________
*** CID 395330: Code maintainability issues (UNUSED_VALUE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 182 in get_clk_freq()
176 case 0:
177 pllm_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLM;
178 pllc_reg = CLKMGR_MAINPLL + main_pllc;
179 pllglob_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLGLOB;
180 break;
181 case CLKMGR_PSRC_PER:
>>> CID 395330: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value "282132672U" to "pllm_reg" here, but that stored value is overwritten before it can be used.
182 pllm_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLM;
183 pllc_reg = CLKMGR_PERPLL + per_pllc;
184 pllglob_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLGLOB;
185 break;
186 default:
187 return 0;
** CID 395329: Code maintainability issues (UNUSED_VALUE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 183 in get_clk_freq()
________________________________________________________________________________________________________
*** CID 395329: Code maintainability issues (UNUSED_VALUE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 183 in get_clk_freq()
177 pllm_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLM;
178 pllc_reg = CLKMGR_MAINPLL + main_pllc;
179 pllglob_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLGLOB;
180 break;
181 case CLKMGR_PSRC_PER:
182 pllm_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLM;
>>> CID 395329: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value from "282132604U + per_pllc" to "pllc_reg" here, but that stored value is overwritten before it can be used.
183 pllc_reg = CLKMGR_PERPLL + per_pllc;
184 pllglob_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLGLOB;
185 break;
186 default:
187 return 0;
188 }
** CID 395328: Control flow issues (DEADCODE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 181 in get_clk_freq()
________________________________________________________________________________________________________
*** CID 395328: Control flow issues (DEADCODE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 181 in get_clk_freq()
175 switch (clk_psrc) {
176 case 0:
177 pllm_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLM;
178 pllc_reg = CLKMGR_MAINPLL + main_pllc;
179 pllglob_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLGLOB;
180 break;
>>> CID 395328: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "case 1U:".
181 case CLKMGR_PSRC_PER:
182 pllm_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLM;
183 pllc_reg = CLKMGR_PERPLL + per_pllc;
184 pllglob_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLGLOB;
185 break;
186 default:
** CID 395327: Code maintainability issues (UNUSED_VALUE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 184 in get_clk_freq()
________________________________________________________________________________________________________
*** CID 395327: Code maintainability issues (UNUSED_VALUE)
/plat/intel/soc/agilex5/soc/agilex5_clock_manager.c: 184 in get_clk_freq()
178 pllc_reg = CLKMGR_MAINPLL + main_pllc;
179 pllglob_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLGLOB;
180 break;
181 case CLKMGR_PSRC_PER:
182 pllm_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLM;
183 pllc_reg = CLKMGR_PERPLL + per_pllc;
>>> CID 395327: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value "282132636U" to "pllglob_reg" here, but that stored value is overwritten before it can be used.
184 pllglob_reg = CLKMGR_PERPLL + CLKMGR_PERPLL_PLLGLOB;
185 break;
186 default:
187 return 0;
188 }
189 pllm_reg = CLKMGR_MAINPLL + CLKMGR_MAINPLL_PLLM;
** CID 395326: Uninitialized variables (UNINIT)
________________________________________________________________________________________________________
*** CID 395326: Uninitialized variables (UNINIT)
/plat/intel/soc/agilex5/bl2_plat_setup.c: 74 in bl2_el3_early_platform_setup()
68 {
69 static console_t console;
70
71 handoff reverse_handoff_ptr;
72
73 generic_delay_timer_init();
>>> CID 395326: Uninitialized variables (UNINIT)
>>> Using uninitialized value "reverse_handoff_ptr.hps_osc_clk_hz" when calling "config_clkmgr_handoff".
74 config_clkmgr_handoff(&reverse_handoff_ptr);
75 mailbox_init();
76 enable_nonsecure_access();
77
78 deassert_peripheral_reset();
79 if (combo_phy_init(&reverse_handoff_ptr) != 0) {
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp5YIaEOLnCdbFI-2FIc4JLP8-2FUmbB2NyPEcjqFJPhqYnGCbuJCc-2BtvVqmFI370Sr9nyYSB6KjGZP4HisQwqHQINdkMh5_rJIKl4NImC2S1pVD9xH-2BTiYorMVvk9q4XtI1ZLWqo3N1oQJh2-2BcSyWFYpGKOwSMil8mNUG3qxnZqtQ001OuCkw7eRSRiB3Ar-2FItftaXgbHzZ1ieS1n1v-2BsekQsokC5IV6L8Lb48YM0aydkPS43tbRvnMMBlYX32taWewcsqR6b-2FXen9QLyRGTe9iytzbZTjkclcsipAqWc3ugEGpOLH-2FXtYwdsNip-2Fa6y9bGQTTBgZg-3D
--
TF-A mailing list -- tf-a@lists.trustedfirmware.org
To unsubscribe send an email to tf-a-leave@lists.trustedfirmware.org