Re: [PATCH v2 1/4] highmem: Enhance is_kmap_addr() to check kmap_local_page() mappings

Christoph Hellwig wrote:

On Fri, Feb 03, 2023 at 08:06:32PM -0800, Ira Weiny wrote:

...

• return addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP);

• return (addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP)) ||

• (addr >= __fix_to_virt(FIX_KMAP_END) &&
  

•  addr < __fix_to_virt(FIX_KMAP_BEGIN));
  

Isn't the second check inverted?

The enum map runs from top down. So I believe this is correct. I tested it with a different series and it worked.

Ira