Re: [PATCH v7 3/5] efi: Add tee-based EFI variable driver

On Tue, 1 Aug 2023 at 00:05, Randy Dunlap rdunlap@infradead.org wrote:

On 7/30/23 23:50, Masahisa Kojima wrote:

...

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 043ca31c114e..aa38089d1e4a 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -287,3 +287,18 @@ config UEFI_CPER_X86 bool depends on UEFI_CPER && X86 default y

+config TEE_STMM_EFI

• tristate "TEE based EFI runtime variable service driver"
  

              TEE-based

OK.

...

• depends on EFI && OPTEE && !EFI_VARS_PSTORE
  

• help
  

•   Select this config option if TEE is compiled to include StandAloneMM
  

•   as a separate secure partition it has the ability to check and store
  

                           partition. It has the ability

OK.

Thank you for your review.

Regards, Masahisa Kojima

...

•   EFI variables on an RPMB or any other non-volatile medium used by
  

•   StandAloneMM.
  

•   Enabling this will change the EFI runtime services from the firmware
  

•   provided functions to TEE calls.
  

•   To compile this driver as a module, choose M here: the module
  

•   will be called tee_stmm_efi.
  

-- ~Randy