Hi Raghu,
We have one failure in the TF-A CI which might be related to removal of the Hypervisor S1 defrag invocations.
https://git.trustedfirmware.org/hafnium/hafnium.git/commit/?id=eb35759c2e4e1...
https://ci.trustedfirmware.org/job/tf-a-ci-gateway/17260/
https://ci-builds.trustedfirmware.org/static-files/HfYGa2MCjUELwyJs27G6Dgby_...
Would you please have a look?
Thanks, Olivier.
Sure. Will take a look.
-----Original Message----- From: Olivier Deprez via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:16 AM To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] removal of hypervisor S1 defrag
Hi Raghu,
We have one failure in the TF-A CI which might be related to removal of the Hypervisor S1 defrag invocations.
https://git.trustedfirmware.org/hafnium/hafnium.git/commit/?id=eb35759c2e4e1 2739e27f606b4f6cb36b2a8e753
https://ci.trustedfirmware.org/job/tf-a-ci-gateway/17260/
https://ci-builds.trustedfirmware.org/static-files/HfYGa2MCjUELwyJs27G6Dgby_ E6dg4xEbyDgJ-a4wBUxNjYzNzQ0MzEwMzY1Ojc6b2RlcHJlejpqb2IvdGYtYS1idWlsZGVyLzEyN TA3NzUvYXJ0aWZhY3Q=/lava-uart0.log
Would you please have a look?
Thanks, Olivier.
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Well, quick look tells me not defragging has caused us to run out of heap (expected side effect). I have https://review.trustedfirmware.org/c/hafnium/project/reference/+/16796 already for other changes to increase the number of heap pages. Is there a way I can trigger CI with that change and see if it fixes the issue? I know it did for some of my other changes.
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 10:47 AM To: 'Olivier Deprez' Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Sure. Will take a look.
-----Original Message----- From: Olivier Deprez via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:16 AM To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] removal of hypervisor S1 defrag
Hi Raghu,
We have one failure in the TF-A CI which might be related to removal of the Hypervisor S1 defrag invocations.
https://git.trustedfirmware.org/hafnium/hafnium.git/commit/?id=eb35759c2e4e1 2739e27f606b4f6cb36b2a8e753
https://ci.trustedfirmware.org/job/tf-a-ci-gateway/17260/
https://ci-builds.trustedfirmware.org/static-files/HfYGa2MCjUELwyJs27G6Dgby_ E6dg4xEbyDgJ-a4wBUxNjYzNzQ0MzEwMzY1Ojc6b2RlcHJlejpqb2IvdGYtYS1idWlsZGVyLzEyN TA3NzUvYXJ0aWZhY3Q=/lava-uart0.log
Would you please have a look?
Thanks, Olivier.
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Hi Raghu
There is no provision to specify the refspec of any hafnium submodule to the CI builder job [1]. I was able to take your patch targeting the project/reference submodule and built the secure hafnium binary locally. All the Cactus based tests passed successfully.
[1] https://ci.trustedfirmware.org/job/tf-a-ci-gateway/build?delay=0sec
Thanks, Madhu
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:50 PM To: raghu.ncstate@icloud.com; Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Well, quick look tells me not defragging has caused us to run out of heap (expected side effect). I have https://review.trustedfirmware.org/c/hafnium/project/reference/+/16796 already for other changes to increase the number of heap pages. Is there a way I can trigger CI with that change and see if it fixes the issue? I know it did for some of my other changes.
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 10:47 AM To: 'Olivier Deprez' Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Sure. Will take a look.
-----Original Message----- From: Olivier Deprez via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:16 AM To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] removal of hypervisor S1 defrag
Hi Raghu,
We have one failure in the TF-A CI which might be related to removal of the Hypervisor S1 defrag invocations.
https://git.trustedfirmware.org/hafnium/hafnium.git/commit/?id=eb35759c2e4e1 2739e27f606b4f6cb36b2a8e753
https://ci.trustedfirmware.org/job/tf-a-ci-gateway/17260/
https://ci-builds.trustedfirmware.org/static-files/HfYGa2MCjUELwyJs27G6Dgby_ E6dg4xEbyDgJ-a4wBUxNjYzNzQ0MzEwMzY1Ojc6b2RlcHJlejpqb2IvdGYtYS1idWlsZGVyLzEyN TA3NzUvYXJ0aWZhY3Q=/lava-uart0.log
Would you please have a look?
Thanks, Olivier.
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Thanks for checking, Madhu. Realized I did not catch this because I had the increased heap size (for different reasons) always in my builds so cactus always passed locally.
-----Original Message----- From: Madhukar Pappireddy Madhukar.Pappireddy@arm.com Sent: Wednesday, September 21, 2022 12:37 PM To: raghu.ncstate@icloud.com; Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: RE: [Hafnium] Re: removal of hypervisor S1 defrag
Hi Raghu
There is no provision to specify the refspec of any hafnium submodule to the CI builder job [1]. I was able to take your patch targeting the project/reference submodule and built the secure hafnium binary locally. All the Cactus based tests passed successfully.
[1] https://ci.trustedfirmware.org/job/tf-a-ci-gateway/build?delay=0sec
Thanks, Madhu
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:50 PM To: raghu.ncstate@icloud.com; Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Well, quick look tells me not defragging has caused us to run out of heap (expected side effect). I have https://review.trustedfirmware.org/c/hafnium/project/reference/+/16796 already for other changes to increase the number of heap pages. Is there a way I can trigger CI with that change and see if it fixes the issue? I know it did for some of my other changes.
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 10:47 AM To: 'Olivier Deprez' Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Sure. Will take a look.
-----Original Message----- From: Olivier Deprez via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:16 AM To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] removal of hypervisor S1 defrag
Hi Raghu,
We have one failure in the TF-A CI which might be related to removal of the Hypervisor S1 defrag invocations.
https://git.trustedfirmware.org/hafnium/hafnium.git/commit/?id=eb35759c2e4e1 2739e27f606b4f6cb36b2a8e753
https://ci.trustedfirmware.org/job/tf-a-ci-gateway/17260/
https://ci-builds.trustedfirmware.org/static-files/HfYGa2MCjUELwyJs27G6Dgby_ E6dg4xEbyDgJ-a4wBUxNjYzNzQ0MzEwMzY1Ojc6b2RlcHJlejpqb2IvdGYtYS1idWlsZGVyLzEyN TA3NzUvYXJ0aWZhY3Q=/lava-uart0.log
Would you please have a look?
Thanks, Olivier.
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
Hi, thanks both. A heap size increase change has been submitted. Hopefully this fixes the TF-A CI issue in the next daily run. Regards, Olivier.
________________________________ From: raghu.ncstate@icloud.com raghu.ncstate@icloud.com Sent: 21 September 2022 22:44 To: Madhukar Pappireddy Madhukar.Pappireddy@arm.com; Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org hafnium@lists.trustedfirmware.org Subject: RE: [Hafnium] Re: removal of hypervisor S1 defrag
Thanks for checking, Madhu. Realized I did not catch this because I had the increased heap size (for different reasons) always in my builds so cactus always passed locally.
-----Original Message----- From: Madhukar Pappireddy Madhukar.Pappireddy@arm.com Sent: Wednesday, September 21, 2022 12:37 PM To: raghu.ncstate@icloud.com; Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: RE: [Hafnium] Re: removal of hypervisor S1 defrag
Hi Raghu
There is no provision to specify the refspec of any hafnium submodule to the CI builder job [1]. I was able to take your patch targeting the project/reference submodule and built the secure hafnium binary locally. All the Cactus based tests passed successfully.
[1] https://ci.trustedfirmware.org/job/tf-a-ci-gateway/build?delay=0sec
Thanks, Madhu
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:50 PM To: raghu.ncstate@icloud.com; Olivier Deprez Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Well, quick look tells me not defragging has caused us to run out of heap (expected side effect). I have https://review.trustedfirmware.org/c/hafnium/project/reference/+/16796 already for other changes to increase the number of heap pages. Is there a way I can trigger CI with that change and see if it fixes the issue? I know it did for some of my other changes.
-----Original Message----- From: Raghu Krishnamurthy via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 10:47 AM To: 'Olivier Deprez' Olivier.Deprez@arm.com; hafnium@lists.trustedfirmware.org Subject: [Hafnium] Re: removal of hypervisor S1 defrag
Sure. Will take a look.
-----Original Message----- From: Olivier Deprez via Hafnium hafnium@lists.trustedfirmware.org Sent: Wednesday, September 21, 2022 12:16 AM To: hafnium@lists.trustedfirmware.org Subject: [Hafnium] removal of hypervisor S1 defrag
Hi Raghu,
We have one failure in the TF-A CI which might be related to removal of the Hypervisor S1 defrag invocations.
https://git.trustedfirmware.org/hafnium/hafnium.git/commit/?id=eb35759c2e4e1 2739e27f606b4f6cb36b2a8e753
https://ci.trustedfirmware.org/job/tf-a-ci-gateway/17260/
https://ci-builds.trustedfirmware.org/static-files/HfYGa2MCjUELwyJs27G6Dgby_ E6dg4xEbyDgJ-a4wBUxNjYzNzQ0MzEwMzY1Ojc6b2RlcHJlejpqb2IvdGYtYS1idWlsZGVyLzEyN TA3NzUvYXJ0aWZhY3Q=/lava-uart0.log
Would you please have a look?
Thanks, Olivier.
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
-- Hafnium mailing list -- hafnium@lists.trustedfirmware.org To unsubscribe send an email to hafnium-leave@lists.trustedfirmware.org
hafnium@lists.trustedfirmware.org
-
Madhukar Pappireddy -
Olivier Deprez -
raghu.ncstate＠icloud.com